Re: [BUGS] 0x1A in control file on Windows - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [BUGS] 0x1A in control file on Windows
Date
Msg-id 48D3B95E.4070704@dunslane.net
Whole thread Raw
In response to Re: [BUGS] 0x1A in control file on Windows  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [BUGS] 0x1A in control file on Windows  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers

Magnus Hagander wrote:
> I had a chat with Heikki about this, and the proper way to fix it.
>
> Should there actually be any reason not to *always* open our files with
> O_BINARY? That seems to be what should mimic what Unix does, which would
> be what we expect, no?
>
> If that is so, then I propose we do that for 8.4, and just backpatch the
> O_BINARY flag to these two locations for 8.3 and 8.2. Thoughts?
>
>
>   

ISTR there are a few places where we want CRLF translation (config files?)

I'd be fairly conservative about making changes like this.

cheers

andrew


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [BUGS] 0x1A in control file on Windows
Next
From: Magnus Hagander
Date:
Subject: Re: [BUGS] 0x1A in control file on Windows