Re: New FSM patch - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: New FSM patch
Date
Msg-id 48D2A49E.8050800@enterprisedb.com
Whole thread Raw
In response to Re: New FSM patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> I did a bit of testing and immediately got an Assert failure:
> 
> ...
> 
> The scary part of that is that it gets through the regression tests ---
> doesn't leave one with a warm feeling about how much of VACUUM gets
> exercised by regression.

Ouch..

> I take it the comment at the top of indexfsm.c about using one bit per
> page should be recast as a possible future improvement?

Yep. I also noted that the code in GetIndexFreeSpace() didn't match the 
comment above it.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: New FSM patch
Next
From: Zdenek Kotala
Date:
Subject: Re: FSM patch - performance test