Why we don't panic in PageGetExactFreeSpace - Mailing list pgsql-hackers

From Zdenek Kotala
Subject Why we don't panic in PageGetExactFreeSpace
Date
Msg-id 4898911D.9000006@sun.com
Whole thread Raw
Responses Re: Why we don't panic in PageGetExactFreeSpace  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
The PageGetExactFreeSpace function contains following code:

00486     space = (int) ((PageHeader) page)->pd_upper -
00487         (int) ((PageHeader) page)->pd_lower;
00488
00489     if (space < 0)
00490         return 0;


It seems to me that we should panic that data are overlaped instead of return 
zero. See PageHeaderIsValid for reference.
Any comments?
    Zdenek

-- 
Zdenek Kotala              Sun Microsystems
Prague, Czech Republic     http://sun.com/postgresql



pgsql-hackers by date:

Previous
From: Markus Wanner
Date:
Subject: Re: Automatic Client Failover
Next
From: "Nikolae Shevchenco (md)"
Date:
Subject: unable to build libpq on Win 2003 (32 bit)