Re: [PATCHES] GIN improvements - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: [PATCHES] GIN improvements
Date
Msg-id 4888D6DB.8030100@sigaev.ru
Whole thread Raw
In response to Re: [PATCHES] GIN improvements  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCHES] GIN improvements  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> queries return the same row twice.  A bitmap indexscan plan would mask
> such an index bug ... but a plain indexscan won't.

Fuh. :(. Well. Will fix.

GiST: - GiST already supports both scan directions in theory, but page split may 
change order between forward and backward scans (user-defined pageSplit doesn't 
preserve order of tuples). Holding of split until end of scan will produce 
unacceptable concurrency level. - GiST  can return one itempointer twice. It's fixable by storing content of 
current page in memory instead of just keeping page pinned. Will do (backpatches 
too).

GIN: - GIN doesn't support backward scan direction and will not support in close 
future. - Right now GIN doesn't return twice the same itempointer, but with current 
fast_insert patch it might return. So, suppose, to fix that it's enough just to 
remember itempointers returned from pending list and use it as filter for 
results from  regular structure. Will do.
-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] WITH RECUSIVE patches 0723
Next
From: Hannu Krosing
Date:
Subject: Re: Do we really want to migrate plproxy and citext into PG core distribution?