Re: [GENERAL] Fragments in tsearch2 headline - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: [GENERAL] Fragments in tsearch2 headline
Date
Msg-id 487C6E12.3030906@sigaev.ru
Whole thread Raw
In response to Re: [GENERAL] Fragments in tsearch2 headline  ("Sushant Sinha" <sushant354@gmail.com>)
Responses Re: [GENERAL] Fragments in tsearch2 headline  (Sushant Sinha <sushant354@gmail.com>)
List pgsql-hackers
> Attached a new patch that:
> 
> 1. fixes previous bug
> 2. better handles the case when cover size is greater than the MaxWords. 

Looks good, I'll make some tests with  real-world application.

> I have not yet added the regression tests. The regression test suite 
> seemed to be only ensuring that the function works. How many tests 
> should I be adding? Is there any other place that I need to add 
> different test cases for the function?

Just add 3-5 selects to src/test/regress/sql/tsearch.sql with checking basic 
functionality and corner cases like - there is no covers in text - Cover(s) is too big - and so on

Add some words in documentation too, pls.


-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/
 


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: [PATCHES] WIP: executor_hook for pg_stat_statements
Next
From: "Xiao Meng"
Date:
Subject: Is there anyway to create a TupleDesc with uint32 attribute easily?