Re: PATCH: CITEXT 2.0 v3 - Mailing list pgsql-hackers

From Zdenek Kotala
Subject Re: PATCH: CITEXT 2.0 v3
Date
Msg-id 4877B67B.6010009@sun.com
Whole thread Raw
In response to PATCH: CITEXT 2.0 v3  ("David E. Wheeler" <david@kineticode.com>)
Responses Re: PATCH: CITEXT 2.0 v3
List pgsql-hackers
David E. Wheeler napsal(a):
> Attached is a new version of a patch to add a CITEXT contrib module. 
> Changes since v2:
> 
> * Optimized citext_eq() and citext_ne() (the = and <> operators, 
> respectively) by having them use strncmp() instead of varstr_cmp(). Per 
> discussion.
> 
> * Added `RESTRICT` and `JOIN` clauses to the comparison operators (=, 
> <>, <, >, <=, >=). These improve statistics estimations, increasing the 
> liklihood that indices will be used.

I'm sorry for late response. I'm little bit busy this week. I quickly look on 
your latest changes and it seems to me that everything is OK. I'm going to 
change status to ready for commit. After discussion with Pavel Stehule I changed 
meaning about pgFoundry vs. contrib. Contrib is OK for me.

Maybe some native speaker should review documentation.
    Zdenek


-- 
Zdenek Kotala              Sun Microsystems
Prague, Czech Republic     http://sun.com/postgresql



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: _bt_delitems: change before WAL?
Next
From: "David E. Wheeler"
Date:
Subject: Re: PATCH: CITEXT 2.0 v3