Re: Offline enabling/disabling of data checksums - Mailing list pgsql-hackers

From Sergei Kornilov
Subject Re: Offline enabling/disabling of data checksums
Date
Msg-id 487091552477419@myt1-4903e6646a45.qloud-c.yandex.net
Whole thread Raw
In response to Re: Offline enabling/disabling of data checksums  (Michael Banck <michael.banck@credativ.de>)
Responses Re: Offline enabling/disabling of data checksums
Re: Offline enabling/disabling of data checksums
List pgsql-hackers
Hi,

>>  > Also we support ./configure --with-blocksize=(not equals 8)? make
>>  > check on HEAD fails for me. If we support this - i think we need
>>  > recheck BLCKSZ between compiled pg_checksum and used in PGDATA
>>
>>  You mean if the backend and pg_checksums is built with different
>>  blocksize? Yeah, that sounds like something which is a cheap check and
>>  should be done.
>
> I've been doing that in my pg_checksums fork for a while (as it further
> removed from the Postgres binaries) but yeah we should check for that as
> well in pg_checksums, see attached patch.

Seems good. And I think we need backpath this check to pg11. similar to cross-version compatibility checks

regards, Sergei


pgsql-hackers by date:

Previous
From: Sergei Kornilov
Date:
Subject: Re: Offline enabling/disabling of data checksums
Next
From: Magnus Hagander
Date:
Subject: Re: Offline enabling/disabling of data checksums