Hi,
>> > Also we support ./configure --with-blocksize=(not equals 8)? make
>> > check on HEAD fails for me. If we support this - i think we need
>> > recheck BLCKSZ between compiled pg_checksum and used in PGDATA
>>
>> You mean if the backend and pg_checksums is built with different
>> blocksize? Yeah, that sounds like something which is a cheap check and
>> should be done.
>
> I've been doing that in my pg_checksums fork for a while (as it further
> removed from the Postgres binaries) but yeah we should check for that as
> well in pg_checksums, see attached patch.
Seems good. And I think we need backpath this check to pg11. similar to cross-version compatibility checks
regards, Sergei