Re: Change pg_cancel_*() to ignore current backend - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Change pg_cancel_*() to ignore current backend
Date
Msg-id 4837.1432129635@sss.pgh.pa.us
Whole thread Raw
In response to Re: Change pg_cancel_*() to ignore current backend  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
Responses Re: Change pg_cancel_*() to ignore current backend  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
List pgsql-hackers
Jim Nasby <Jim.Nasby@BlueTreble.com> writes:
> On 5/19/15 9:19 PM, Fabrízio de Royes Mello wrote:
>> +1 to add a second parameter to current functions.

> Instead of allow_own_pid, I went with skip_own_pid. I have the function 
> still returning true even when it skips it's own PID... that seems a bit 
> weird, but I think it's better than returning false. Unless someone 
> thinks it should return NULL, but I don't see that as any better either.

The implementation would probably be considerably simpler if you treated
these as separate functions at the SQL/C level, ie overload rather than
try to treat the added parameter as having a default.
        regards, tom lane



pgsql-hackers by date:

Previous
From: "Shulgin, Oleksandr"
Date:
Subject: [PATCH] Generalized JSON output functions
Next
From: Amit Kapila
Date:
Subject: Issues in Replication Progress Tracking