Re: [HACKERS] use of pager on Windows psql - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: [HACKERS] use of pager on Windows psql
Date
Msg-id 483037D9.1030900@dunslane.net
Whole thread Raw
In response to Re: [HACKERS] use of pager on Windows psql  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches

Bruce Momjian wrote:
>
>
>> This broke the buildfarm and finally explains the following kluge which
>> has been puzzling me for four years:
>>
>>         /*
>>          * for some reason MinGW (and MSVC) outputs an extra newline, so
>> this
>>          * suppresses it
>>          */
>> #ifndef WIN32
>>         fputc('\n', fout);
>> #endif
>>
>> I have removed the kluge (and yes, I tested it).
>>
>
> Oh, that kluge.  Why did the isatty() addition fix this?  Was the pager
> being used on Win32 for the regression tests and somehow eating a line
> or something?
>

It apparently produced an extra line which we had compensated for with
the kluge (without really understanding why we had to).

Anyway, all is good now, as the buildfarm shows.

cheers

andrew

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] use of pager on Windows psql
Next
From: Andrew Chernow
Date:
Subject: Re: libpq object hooks (libpq events)