Re: DROP DATABASE vs patch to not remove files right away - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: DROP DATABASE vs patch to not remove files right away
Date
Msg-id 48055912.2020109@dunslane.net
Whole thread Raw
In response to Re: DROP DATABASE vs patch to not remove files right away  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
>   
>> Tom Lane wrote:
>>     
>>> I think that it should be coded
>>> to ignore ENOENT the same as the bgwriter does, and that it should press
>>> on and keep trying to delete things even if it gets a failure.
>>>       
>
>   
>> Perhaps, if it gets ENOENT, record this fact -- and after rmtree
>> returns, retry the whole thing.
>>     
>
> Er, retry what?  There was, presumably, nothing to delete.
>
>             
>   

Yeah. I agree rmtree() should treat ENOENT as non-fatal.

cheers

andrew


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: DROP DATABASE vs patch to not remove files right away
Next
From: "Stephen Denne"
Date:
Subject: Re: count(*) performance improvement ideas