pg_regress: paths in largeobject test - Mailing list pgsql-patches

Hi,

the largeobject test does this:

137 SELECT lo_export(loid, '@abs_builddir@/results/lotest.txt') <snip>
138
139 \lo_import 'results/lotest.txt'
140
141 \set newloid :LASTOID
142
143 -- just make sure \lo_export does not barf
144 \lo_export :newloid 'results/lotest2.txt'

I believe the results paths in line 139 and 144 are missing the
@abs_builddir@ qualifier.

The attached patch has been tested with "make check" and by running
pg_regress outside the PostgreSQL source tree, both on Solaris 11, x86.

-J
--

Jørgen Austvik, Software Engineering - QA
Sun Microsystems Database Technology Group
Index: src/test/regress/input/largeobject.source
===================================================================
RCS file: /projects/cvsroot/pgsql/src/test/regress/input/largeobject.source,v
retrieving revision 1.4
diff -c -r1.4 largeobject.source
*** src/test/regress/input/largeobject.source    3 Mar 2007 22:57:03 -0000    1.4
--- src/test/regress/input/largeobject.source    29 Nov 2007 11:55:07 -0000
***************
*** 136,147 ****

  SELECT lo_export(loid, '@abs_builddir@/results/lotest.txt') FROM lotest_stash_values;

! \lo_import 'results/lotest.txt'

  \set newloid :LASTOID

  -- just make sure \lo_export does not barf
! \lo_export :newloid 'results/lotest2.txt'

  -- This is a hack to test that export/import are reversible
  -- This uses knowledge about the inner workings of large object mechanism
--- 136,147 ----

  SELECT lo_export(loid, '@abs_builddir@/results/lotest.txt') FROM lotest_stash_values;

! \lo_import '@abs_builddir@/results/lotest.txt'

  \set newloid :LASTOID

  -- just make sure \lo_export does not barf
! \lo_export :newloid '@abs_builddir@/results/lotest2.txt'

  -- This is a hack to test that export/import are reversible
  -- This uses knowledge about the inner workings of large object mechanism
Index: src/test/regress/output/largeobject.source
===================================================================
RCS file: /projects/cvsroot/pgsql/src/test/regress/output/largeobject.source,v
retrieving revision 1.4
diff -c -r1.4 largeobject.source
*** src/test/regress/output/largeobject.source    3 Mar 2007 22:57:04 -0000    1.4
--- src/test/regress/output/largeobject.source    29 Nov 2007 11:55:07 -0000
***************
*** 251,260 ****
           1
  (1 row)

! \lo_import 'results/lotest.txt'
  \set newloid :LASTOID
  -- just make sure \lo_export does not barf
! \lo_export :newloid 'results/lotest2.txt'
  -- This is a hack to test that export/import are reversible
  -- This uses knowledge about the inner workings of large object mechanism
  -- which should not be used outside it.  This makes it a HACK
--- 251,260 ----
           1
  (1 row)

! \lo_import '@abs_builddir@/results/lotest.txt'
  \set newloid :LASTOID
  -- just make sure \lo_export does not barf
! \lo_export :newloid '@abs_builddir@/results/lotest2.txt'
  -- This is a hack to test that export/import are reversible
  -- This uses knowledge about the inner workings of large object mechanism
  -- which should not be used outside it.  This makes it a HACK
Index: src/test/regress/output/largeobject_1.source
===================================================================
RCS file: /projects/cvsroot/pgsql/src/test/regress/output/largeobject_1.source,v
retrieving revision 1.1
diff -c -r1.1 largeobject_1.source
*** src/test/regress/output/largeobject_1.source    10 Mar 2007 03:42:19 -0000    1.1
--- src/test/regress/output/largeobject_1.source    29 Nov 2007 11:55:07 -0000
***************
*** 251,260 ****
           1
  (1 row)

! \lo_import 'results/lotest.txt'
  \set newloid :LASTOID
  -- just make sure \lo_export does not barf
! \lo_export :newloid 'results/lotest2.txt'
  -- This is a hack to test that export/import are reversible
  -- This uses knowledge about the inner workings of large object mechanism
  -- which should not be used outside it.  This makes it a HACK
--- 251,260 ----
           1
  (1 row)

! \lo_import '@abs_builddir@/results/lotest.txt'
  \set newloid :LASTOID
  -- just make sure \lo_export does not barf
! \lo_export :newloid '@abs_builddir@/results/lotest2.txt'
  -- This is a hack to test that export/import are reversible
  -- This uses knowledge about the inner workings of large object mechanism
  -- which should not be used outside it.  This makes it a HACK