Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] postgres_fdw : altering foreign table not invalidatingprepare statement execution plan. - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: [HACKERS] postgres_fdw : altering foreign table not invalidatingprepare statement execution plan.
Date
Msg-id 470bc9e4-3467-fced-7563-fc4d8210c557@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] postgres_fdw : altering foreign table not invalidatingprepare statement execution plan.  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
Responses Re: [HACKERS] postgres_fdw : altering foreign table not invalidatingprepare statement execution plan.  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
Tree view 
On 2017/01/03 15:57, Ashutosh Bapat wrote:
> The patch looks good to me, but I feel there are too many testscases.
> Now that we have changed the approach to invalidate caches in all
> cases, should we just include cases for SELECT or UPDATE or INSERT or
> DELETE instead of each statement?

I don't object to that, but (1) the tests I added wouldn't be that 
time-consuming, and (2) they would be more expected to help find bugs, 
in general, so I'd vote for keeping them.  How about leaving that for 
the committer's judge?

Thanks for the review!

Best regards,
Etsuro Fujita

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] Declarative partitioning - another take
Next
From: Fabien COELHO
Date:
Subject: Re: [HACKERS] pgbench - allow to store select results intovariables