Re: AbstractJdbc2Array - another patch - Mailing list pgsql-jdbc

From Heikki Linnakangas
Subject Re: AbstractJdbc2Array - another patch
Date
Msg-id 470E0262.2050704@enterprisedb.com
Whole thread Raw
In response to AbstractJdbc2Array - another patch  (Marek Lewczuk <newsy@lewczuk.com>)
List pgsql-jdbc
Marek Lewczuk wrote:
> in the attachment you can find AbstractJdbc2Array with small patch
> (empty array was wrongly interpreted). Please test it and if possible
> add to cvs.

There seems to be a lot of unrelated stylistic changes, whitespace
changes, renaming of fields etc. in that new file. That makes it hard to
see what the problem is that it's fixing, and what was done to fix it.
Please make just the changes required to fix the problem, and if you
want to propose any other changes, send them as separate patches.

Also, please send patches in a "cvs diff -c" format, instead of sending
the whole file.

A small test case demonstrating the problem would also be very nice, to
help with the testing.

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

pgsql-jdbc by date:

Previous
From: Marek Lewczuk
Date:
Subject: AbstractJdbc2Array - another patch
Next
From: "Brian Oki (boki)"
Date:
Subject: Support for distributed transactions