Re: meson: Specify -Wformat as a common warning flag for extensions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: meson: Specify -Wformat as a common warning flag for extensions
Date
Msg-id 4707d4ed-f268-43c0-b4dd-cdbc7520f508@eisentraut.org
Whole thread Raw
In response to Re: meson: Specify -Wformat as a common warning flag for extensions  (Sutou Kouhei <kou@clear-code.com>)
Responses Re: meson: Specify -Wformat as a common warning flag for extensions
List pgsql-hackers
On 07.04.24 18:01, Sutou Kouhei wrote:
> +# We don't have "warning_level == 3" and "warning_level ==
> +# 'everything'" here because we don't use these warning levels.
> +if warning_level == '1'
> +  common_builtin_flags += ['-Wall']
> +elif warning_level == '2'
> +  common_builtin_flags += ['-Wall', '-Wextra']
> +endif

I would trim this even further and always export just '-Wall'.  The 
other options aren't really something we support.

The other stanzas, on '-g' and '-O*', look good to me.




pgsql-hackers by date:

Previous
From: Pradeep Kumar
Date:
Subject: Re: Need clarification on compilation errors in PG 16.2
Next
From: Peter Eisentraut
Date:
Subject: meson "experimental"?