Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Remove QueryOperand->istrue flag, it was used only in cover - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Remove QueryOperand->istrue flag, it was used only in cover
Date
Msg-id 46E6DC9E.2000500@enterprisedb.com
Whole thread Raw
In response to pgsql: Remove QueryOperand->istrue flag, it was used only in cover  (teodor@postgresql.org (Teodor Sigaev))
Responses Re: pgsql: Remove QueryOperand->istrue flag, it was used only in cover
List pgsql-committers
Tree view 
Teodor Sigaev wrote:
> Remove QueryOperand->istrue flag, it was used only in cover ranking
> (ts_rank_cd). Use palloc'ed array in ranking instead of flag.

Nice, I played around that myself as well today. I tried to use
Bitmapsets, instead of bool arrays, but that turned out to be
significantly slower than the way it used to be. It looks like that
bool-array method isn't, so that's good.

Increasing the length field in QueryOperand doesn't actually help,
because TSVector still only uses 11-bits for the length. And there's
checks in tsquery.c that forbid values longer than MAXSTRLEN=2^11-1 anyway.

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Sync timezone data with 2007g zic release.
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Give ICC its preferred, documented form of the no-strict-aliasing