> What I will do instead is adjust parse_coerce.c so that a
> length-coercion function can have either of the signatures
> foo(foo,int4) returns foo
> or
> foo(foo,int4,bool) returns foo
> and then modify the above-mentioned length coercion functions to provide
> the desired behavior. This has no direct impact on pg_cast because we
> do not use pg_cast for length-coercion functions.
Sounds good to me.
When those are really truncated ESQL/C needs to set a warning in sqlca.sqlwarn
though, thus I think the second signature should also have an output flag to tell
whether truncation actually occurred.
Maybe this should be kept for a protocol change though, since I would not think
a NOTICE would be suitable here.
Andreas
