Re: Beta going well - Mailing list pgsql-hackers

From Zeugswetter Andreas SB SD
Subject Re: Beta going well
Date
Msg-id 46C15C39FEB2C44BA555E356FBCD6FA41EB3EC@m0114.s-mxs.net
Whole thread Raw
In response to Beta going well  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Beta going well
Re: Beta going well
Re: Beta going well
List pgsql-hackers
> > Anyone have stuff that they need to get in there before beta2?
> 
> Yes. doesn't compile on AIX 5L. I would like to fix it before beta2
> (see attached pacthes below).

IIRC not all (old) versions of AIX define those, thus your patch would 
break those that havent :-( I am not sure we care about those old
versions
anymore though. 
Also I actually see those defines as a bug in AIX, since a comment
states,
that BSD requires them, I certainly havent heard BSD'ers complain about 
redefines ?

Also I don't understand why your compiler stops ? Mine only give a
warning.

These defines are only included if _ALL_SOURCE is defined. I think this
define 
stems from another system header file, that gets included somewhere
else.
Maybe a better fix would be to #undef _ALL_SOURCE before including
inttypes.h ?

Andreas


pgsql-hackers by date:

Previous
From: "Balaji Venkatesan"
Date:
Subject: Limitations on PGSQL
Next
From: "Zeugswetter Andreas SB SD"
Date:
Subject: Re: Beta going well