Re: write_pipe_chunks patch messes up early error message output - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: write_pipe_chunks patch messes up early error message output
Date
Msg-id 469FB89E.7060902@dunslane.net
Whole thread Raw
In response to Re: write_pipe_chunks patch messes up early error message output  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>   
>> Anyway, I think the attached patch will do what we need.
>>     
>
> I think you could leave Redirect_stderr out of the elog.c tests
> entirely, since redirection_done can never become set without it.
>
> Also, you introduced a bug: pgwin32_is_service is a function no?
> Needs invocation parens.
>
> Otherwise looks reasonable.
>
>             
>   

Thanks. Applied with those fixes, back as far as 8.0.

cheers

andrew


pgsql-hackers by date:

Previous
From: "Dave Page"
Date:
Subject: Re: 8.3 Release Schedule
Next
From: "Joshua D. Drake"
Date:
Subject: Re: 8.3 Release Schedule