Postgres Pro
Downloads
Home   >   mailing lists

Re: write_pipe_chunks patch messes up early error message output - Mailing list pgsql-hackers

From Tom Lane
Subject Re: write_pipe_chunks patch messes up early error message output
Date
Msg-id 12929.1184866456@sss.pgh.pa.us
Whole thread Raw
In response to Re: write_pipe_chunks patch messes up early error message output  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: write_pipe_chunks patch messes up early error message output  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Tree view 
Andrew Dunstan <andrew@dunslane.net> writes:
> Anyway, I think the attached patch will do what we need.

I think you could leave Redirect_stderr out of the elog.c tests
entirely, since redirection_done can never become set without it.

Also, you introduced a bug: pgwin32_is_service is a function no?
Needs invocation parens.

Otherwise looks reasonable.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: write_pipe_chunks patch messes up early error message output
Next
From: Bruce Momjian
Date:
Subject: 8.3 Release Schedule