Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.
Date
Msg-id 4631.1444703467@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> On Tue, Oct 13, 2015 at 8:35 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Cause TestLib.pm to define $windows_os in all branches.
>> 
>> Back-port of a part of commit 690ed2b76ab91eb79ea04ee2bfbdc8a2693f2a37 that
>> I'd depended on without realizing that it was only added recently.  Since
>> it seems entirely likely that other such tests will need to be back-patched
>> in future, providing the flag seems like a better answer than just putting
>> a test in-line.

> Is it really worth it back-patching the portions with $windows_os to
> back-branches? This indeed makes back-patch a bit easier but the tests
> cannot run on Windows because 13d856e1 has not been added in PG <=
> 9.5.

Hmm, well, why wasn't that back-patched?  We expect these tests to run
on Windows don't we?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Re: [BUGS] BUG #13611: test_postmaster_connection failed (Windows, listen_addresses = '0.0.0.0' or '::')
Next
From: Tom Lane
Date:
Subject: Re: bugs and bug tracking