Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.
Date
Msg-id CAB7nPqTMqZADJYmYNdxSoT_S4J2p0pKYFWC_F2YVhOMeTake8g@mail.gmail.com
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Oct 13, 2015 at 8:35 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Cause TestLib.pm to define $windows_os in all branches.
>
> Back-port of a part of commit 690ed2b76ab91eb79ea04ee2bfbdc8a2693f2a37 that
> I'd depended on without realizing that it was only added recently.  Since
> it seems entirely likely that other such tests will need to be back-patched
> in future, providing the flag seems like a better answer than just putting
> a test in-line.

Is it really worth it back-patching the portions with $windows_os to
back-branches? This indeed makes back-patch a bit easier but the tests
cannot run on Windows because 13d856e1 has not been added in PG <=
9.5.
-- 
Michael



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Parallel Aggregate
Next
From: Michael Paquier
Date:
Subject: Re: bugs and bug tracking