Re: pg_resetxlog bug? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_resetxlog bug?
Date
Msg-id 4601.1241392629@sss.pgh.pa.us
Whole thread Raw
In response to pg_resetxlog bug?  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Fujii Masao <masao.fujii@gmail.com> writes:
> Current pg_resetxlog doesn't remove any archive status files. This
> may cause continuous failure of archive command since .ready file
> remains even if a corresponding XLOG segment is removed. And,
> .done file without XLOG segment cannot be removed by checkpoint,
> and would remain forever. These are undesirable behaviors.

> I think that pg_resetxlog should remove existing archive status files
> of XLOG segments. Here is the patch to do so.

Applied with a trivial fix (the ending value of "path" isn't necessarily
right for a complaint about directory read failure, so use a constant
instead).

I back-patched as far as 8.1.  The issue exists in 8.0 too, but the
patch didn't apply immediately to 8.0 because of the above issue.
Given the lack of field complaints and 8.0's rather legacy status,
it didn't seem worth expending extra effort on.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: windows doesn't notice backend death
Next
From: Alvaro Herrera
Date:
Subject: Re: windows doesn't notice backend death