Re: [Patch] Make pg_checksums skip foreign tablespace directories - Mailing list pgsql-hackers

From David Steele
Subject Re: [Patch] Make pg_checksums skip foreign tablespace directories
Date
Msg-id 45f6d9c5-ad73-b20b-dd03-f9c3770c54b9@pgmasters.net
Whole thread Raw
In response to Re: [Patch] Make pg_checksums skip foreign tablespace directories  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi Michael,

On 2/24/20 7:26 AM, Michael Paquier wrote:
> On Sun, Feb 23, 2020 at 04:08:58PM +0900, Michael Paquier wrote:
>> Good idea.  Let's do things as you suggest.
> 
> Applied and back-patched this one down to 11.

FWIW, we took a slightly narrower approach to this issue in the 
pgBackRest patch (attached).

I don't have an issue with the prefix approach since it works and the 
Postgres project is very likely to catch it if there is a change in 
behavior.

For third-party projects, though, it might pay to be more conservative 
in case the behavior changes in the future, i.e. 
pg_internal.init[something] (but not pg_internal\.init[0-9]+) becomes valid.

Regards,
-- 
-David
david@pgmasters.net

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Memory-Bounded Hash Aggregation
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.