Re: pg_stat_get_activity(): integer overflow due to (int) * (int) for MemoryContextAllocHuge() - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pg_stat_get_activity(): integer overflow due to (int) * (int) for MemoryContextAllocHuge()
Date
Msg-id 45ba068b-66ea-b74c-5a92-6c2127d63e28@eisentraut.org
Whole thread Raw
In response to Re: pg_stat_get_activity(): integer overflow due to (int) * (int) for MemoryContextAllocHuge()  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pg_stat_get_activity(): integer overflow due to (int) * (int) for MemoryContextAllocHuge()
List pgsql-hackers
On 27.09.23 09:08, Michael Paquier wrote:
> On Wed, Sep 27, 2023 at 08:41:55AM +0200, Jakub Wartak wrote:
>> Attached patch adjusts pgstat_track_activity_query_size to be of
>> size_t from int and fixes the issue.
> 
> This cannot be backpatched, and using size_t is not really needed as
> track_activity_query_size is capped at 1MB.  Why don't you just tweak
> the calculation done in pgstat_read_current_status() instead, say with
> a cast?

I think it's preferable to use the right type to begin with, rather than 
fixing it up afterwards with casts.




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Is this a problem in GenericXLogFinish()?
Next
From: Jeff Davis
Date:
Subject: Re: Is this a problem in GenericXLogFinish()?