Re: Bison 2.1 on win32 - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Bison 2.1 on win32
Date
Msg-id 45FBF721.7020808@dunslane.net
Whole thread Raw
In response to Bison 2.1 on win32  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander wrote:
> I just tried building with Bison 2.1 on msvc, and it broke. For one
> thing, the .BAT file rejects 2.1 as broken instead of 2.0, which is
> obviously incorrect :-)
>
> But the generated C file also does not compile causing the error on
> http://msdn2.microsoft.com/en-us/library/93az0868.aspx, because msvc
> doesn't define __STDC__, which causes Bison to generate code it can't
> compile.  Defining __STDC__ globally breaks several other places, since
> it affects a lot of include files that aren't necessarily others.
>
> The attached patch seems to fix the build issue. Does it seem
> acceptable/the right thing to do?
>
> Another option would be to just reject both 2.0 and 2.1 as broken to
> build pg with, I guess...
>
>   

I rolled back to 1.875 to get MSVC builds working. In the longer term, 
though, falling behind upstream is probably not a good idea. Should this 
be reported to the bison people?

For now I could live with either of your solutions.

cheers

andrew


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Bison 2.1 on win32
Next
From: "Joshua D. Drake"
Date:
Subject: Re: [PATCHES] Bitmapscan changes