Re: [COMMITTERS] pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain. - Mailing list pgsql-hackers

From Dave Page
Subject Re: [COMMITTERS] pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain.
Date
Msg-id 45F173F4.9010609@postgresql.org
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain.  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Re: [COMMITTERS] pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Magnus Hagander wrote:

> In which case it can simply be because I was building against a libpq
> built with MSVC = it had the broken startup code, and you used a mingw
> one, which didn't have it.

Maybe - but it does imply it's potentially easy to break code with this 
change.

> Per the docs, an application like slon *should* make it's own call to
> WSAStartup() because it uses socket functions diretly (port/pipe.c)...
> 
> 
> Another question related to backpatching - should I backpatch this to
> 8.1 and 8.0 as well? I know we said we more or less don't maintain the
> win32 port back there because it was too new, but this is all code in
> the client libpq, which has been around no win32 much longer. The reason
> I'm asking is that the original reporter of this problem is on 8.1...
> 
> I'm leaning towards yes, but would like to hear further comments...

I'm far from convinced it should be backpatched at all.

/D


pgsql-hackers by date:

Previous
From: "Simon Riggs"
Date:
Subject: Interaction of PITR backups and Bulk operations avoiding WAL
Next
From: Martijn van Oosterhout
Date:
Subject: Re: Calculated view fields (8.1 != 8.2)