Re: Patch for column properties - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: Patch for column properties
Date
Msg-id 45EAA95D.9020708@lelarge.info
Whole thread Raw
In response to Re: Patch for column properties  (Dave Page <dpage@postgresql.org>)
List pgadmin-hackers
Dave Page a écrit :
> [...]
>> And one more question, I wonder why the SQL tab is not editable ? I
>> can think of one reason but I'm not sure :)
>
> Because it's dynamically generated, and any changes would either be lost
> if the user changed tab, or would have to be reverse engineered back
> into the other dialog controls.

There's probably another way of doing it. We can add a checkbox on the
SQL tab. If the user clicks on it, it enables editing the SQL text field
and pgAdmin disables the other tabs so we don't have to reverse
engineer. If the user clicks on it once again, pgAdmin re-enables the
other tabs, disables editing the SQL text field and refresh its content.

> Also, on some dialogs there are
> placeholders included in the code for cases when we have multi-step
> queries that are tied together by a generated ID. IF the user mucked
> about with those, it could break things particularly spectaularly.
>

But this would not work with such a checkbox.

Regards.


--
Guillaume.
<!-- http://abs.traduc.org/
      http://lfs.traduc.org/
      http://docs.postgresqlfr.org/ -->

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: Patch for column properties
Next
From: Dave Page
Date:
Subject: Re: Patch for column properties