Re: Request for review: tsearch2 patch - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: Request for review: tsearch2 patch
Date
Msg-id 45A50B54.6090608@sigaev.ru
Whole thread Raw
In response to Re: Request for review: tsearch2 patch  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: Request for review: tsearch2 patch  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Re: Request for review: tsearch2 patch  (Tatsuo Ishii <ishii@postgresql.org>)
List pgsql-hackers
> I have tested with local-enabled environment and found a bug. Included
> is the new version of patches. 
Your patch causes crash on tsearch2's installcheck with 'initdb -E UTF8 --locale 
C', simple way to reproduce:
# select to_tsquery('default', '''New York''');
server closed the connection unexpectedly        This probably means the server terminated abnormally        before or
whileprocessing the request.
 
The connection to the server was lost. Attempting reset: Failed.


>> ! static int p_isalnum(TParser *prs) {
...
>> !         if (lc_ctype_is_c())
>> !         {
>> !             if (c > 0x7f)
>> !                 return 1;

I have some some doubts that any character greater than 0x7f is an alpha symbol. 
Is it simple assumption or workaround?

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Mark/Restore and avoiding RandomAccess sorts
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] Last infomask bit