Re: [COMMITTERS] pgsql: another try at keeping AIX/ppc - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [COMMITTERS] pgsql: another try at keeping AIX/ppc
Date
Msg-id 44C93A99.9070000@dunslane.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: another try at keeping AIX/ppc  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: another try at keeping AIX/ppc  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>   
>> Maybe we need to try to stress test the comparison routines a bit to 
>> make sure they really are deterministic.
>>     
>
> Eyeball inspection shows that cube_cmp is wrong: it's doing
> PG_RETURN_INT16 where it should say PG_RETURN_INT32.
>   


ouch, good catch!


> As best I can tell, the committed expected file is actually wrong.
> I'm going to patch both cube.out and cube_1.out to match what I
> get after fixing the function, and we'll see where that takes us.
>
> I notice that cube_2.out hasn't been updated.  Was that intentional?
>   


Well, I was going to wait to see a buildfarm member that needed the 
alternative exponent representation, and use the regression diff as a 
template

cheers

andrew



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] extension for sql update
Next
From: Tom Lane
Date:
Subject: Re: GUC with units, details