Re: [PATCHES] Patch for VS.Net 2005's strxfrm() bug - Mailing list pgsql-hackers

From Florian G. Pflug
Subject Re: [PATCHES] Patch for VS.Net 2005's strxfrm() bug
Date
Msg-id 44C80BD3.5060306@phlo.org
Whole thread Raw
In response to Re: [PATCHES] Patch for VS.Net 2005's strxfrm() bug  (Bruce Momjian <bruce@momjian.us>)
Responses Re: [PATCHES] Patch for VS.Net 2005's strxfrm() bug  (andrew@dunslane.net)
List pgsql-hackers
Bruce Momjian wrote:
>>> Why is this better than:
>>>
>>>   #if _MSC_VER == 1400
>>>
>>>
>>> Surely this will not be true if _MSC_VER is undefined?
>> I experienced injustice and the reason of in OSX for it.
>
> What was the problem with OSX?  Did it throw a warning of you did an
> equality test on an undefined symbol?

The following if evaluated to true on osx, although I'm pretty sure that
_MSC_VER isn't defined on osx ;-)
#if (_MSC_VER < 1300)
...
#endif

replacing it with
#ifdef WIN32
#if (_MSC_VER < 1300)
...
#endif
#endif

fixed the problem.

greetings, Florian Pflug



pgsql-hackers by date:

Previous
From: Michael Glaesemann
Date:
Subject: Re: GUC with units, details
Next
From: andrew@dunslane.net
Date:
Subject: Re: [PATCHES] Patch for VS.Net 2005's strxfrm() bug