Re: Lightspeed for frmQuery and other issues. - Mailing list pgadmin-hackers

From Andreas Pflug
Subject Re: Lightspeed for frmQuery and other issues.
Date
Msg-id 4454D766.3080502@pse-consulting.de
Whole thread Raw
In response to Re: Lightspeed for frmQuery and other issues.  ("Edward Di Geronimo Jr." <edigeronimo@xtracards.com>)
Responses Re: Lightspeed for frmQuery and other issues.
List pgadmin-hackers
Edward Di Geronimo Jr. wrote:
> Quoting Andreas Pflug <pgadmin@pse-consulting.de>:
>
>> Simply select some non-adjacent cells in arbitrary cols and rows.
>
>
> I stated that in the beginning, and asked if anyone had any  suggestions
> on what to do in that case. If you completely arbitrarily  hightlight
> cells, there really isn't a way to store them in the  clipboard. Because
> no one had any suggestions on how to handle it,  yourself included, the
> decision was made to just copy the first group  of cells highlighted.

I still don't see a need for that extended handling, because the ctl
always allowed row selections (and column selections can be achieved
from SELECT ...., a basic SQL feature... )
>
>> The implementation did not meet the primary requirement, so I objected
>> clearly and early. You decided to commit an half-brewn "enhancement"
>> based on a technique that was known not to meet the TODO, i.e. doing it
>> with a virtual control. You can't be too surprised I basically rolled
>> back that beast, to have the first step made before the second.
>
>
> Users dont care about virtual controls or not.

They do. It's the speed issue, esp. on non-win32.

> Users care about basic
> functionality like being able to copy subsets of data into the
> clipboard. Only behing able to copy entire rows at a time is a half
> brewn implementation. It would have been much easier for you to
> refactor things into a virtual table

Wrong. Look at the current implementation, which basically takes version
5021 and *removes* 100 lines of code.

> Also, you're forgetting that the only reason I didn't implement code
> similar to this originally is because you were rather insistant that
> the data retrieval code should not be changed in any way. It's not
> exactly reasonable to place restrictions on other people's work simply
> so that you can later complain that the work isn't good enough and  have
> an excuse to rip it out.

Not quite, I always insisted on doing it "the virtual way" and made
quite clear that I'd enforce it. Explaining how to do it required more
work than to do it, I said that earlier. See how it works now, and do it
with wxGrid if you like.

Regards,
Andreas

pgadmin-hackers by date:

Previous
From: svn@pgadmin.org
Date:
Subject: SVN Commit by andreas: r5104 - in trunk/pgadmin3: . src/ctl src/frm src/include
Next
From: Andreas Pflug
Date:
Subject: Re: Lightspeed for frmQuery and other issues.