Re: [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags
Date
Msg-id 44436120-2AC2-487C-A807-F7C0EE4963AD@yesql.se
Whole thread Raw
In response to RE: [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags  (Itamar Gafni <itamar.gafni@imperva.com>)
Responses Re: [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags
List pgsql-hackers
> On 12 Aug 2021, at 12:00, Itamar Gafni <itamar.gafni@imperva.com> wrote:

> Copying it means there are two BIO_METHOD objects with the same type (ortig
> socket and its copy) but it's unclear if that's an issue.


Reading code there doesn't seem to be a concensus really, Apple is doing it in
the Swift TLS code but otheres aren't.  Considering there's been no complaints
on this and OpenSSL < 1.1.0 is EOL I say we leave it for now.

Barring objections I will go ahead with your proposed patch on HEAD and
backpatch it all the way, once I've done more testing on it.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: call popcount32/64 directly on non-x86 platforms
Next
From: David Rowley
Date:
Subject: Re: call popcount32/64 directly on non-x86 platforms