Re: [HACKERS] pg_get_object_address() doesn't support composites - Mailing list pgsql-hackers

From Jim Nasby
Subject Re: [HACKERS] pg_get_object_address() doesn't support composites
Date
Msg-id 4429fd84-0838-7582-09a2-31b6c6ac74dc@BlueTreble.com
Whole thread Raw
In response to Re: [HACKERS] pg_get_object_address() doesn't support composites  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [HACKERS] pg_get_object_address() doesn't support composites  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
List pgsql-hackers
On 2/17/17 9:53 PM, Alvaro Herrera wrote:
> Jim Nasby wrote:
>> See below. ISTM that pg_get_object_address should support everything
>> pg_identify_object_as_address can output, no?
>>
>> I'm guessing the answer here is to have pg_identify_object_as_address
>> complain if you ask it for something that's not mapable.
> Yes, I think we should just reject the case in
> pg_identify_object_as_address.

Attached patch does that, and tests for it. Note that there were some 
unsupported types that were not being tested before. I've added a 
comment requesting people update the test if they add more types.
-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Keeping pg_recvlogical's "feTimestamp" separate from TimestampTz
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Add new function dsa_allocate0.