Re: TODO item: list prepared queries - Mailing list pgsql-patches

From Neil Conway
Subject Re: TODO item: list prepared queries
Date
Msg-id 43B63D1F.9060700@samurai.com
Whole thread Raw
In response to Re: TODO item: list prepared queries  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: TODO item: list prepared queries
List pgsql-patches
Bruce Momjian wrote:
> I have applied the following patch to CVS HEAD to mark client-side
> prepare/bind/execute statements with "[client]" so they can be easily
> distinguished from SQL commands.

There is no such thing as a "client-side prepare/bind/execute"
statement. The distinction is between SQL-level and protocol-level
prepared queries. "[client]" seems wrong; perhaps "[protocol]" could be
used instead?

(I'm not thrilled by the idea of prefixing the statement log with
"[...]" in any case: it makes it more difficult to determine the actual
query string submitted by the user. However I can't see a better
alternative...)

> I hesitate to apply this logging change to 8.1.X.

I don't see any reason to do that -- this is not a bug fix. Furthermore,
there are backward-compatibility concerns.

-Neil


pgsql-patches by date:

Previous
From: Sagi Bashari
Date:
Subject: Re: [BUGS] BUG #2120: Crash when doing UTF8<->ISO_8859_8
Next
From: "Magnus Hagander"
Date:
Subject: LDAP auth