Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local - Mailing list pgsql-hackers

From Tom Lane
Subject Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local
Date
Msg-id 438139.1672272335@sss.pgh.pa.us
Whole thread Raw
In response to Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local  (Andres Freund <andres@anarazel.de>)
Responses Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2022-12-28 13:43:27 -0500, Tom Lane wrote:
>> Hmm ... I guess the buildfarm would tell us whether that detection works
>> correctly on platforms where it matters.  Let's keep it simple if we
>> can.

> Quick clarification question: Are you suggesting to use #ifdef __GNUC__, or
> that it suffices to use -Werror=unknown-pragmas without a separate configure
> check?

I'd try -Werror=unknown-pragmas, and then go to the #ifdef if that
doesn't seem to work well.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local
Next
From: Andres Freund
Date:
Subject: Re: Avoiding unnecessary clog lookups while freezing