Re: PQunescapeBytea code - Mailing list pgsql-hackers

From Tom Lane
Subject Re: PQunescapeBytea code
Date
Msg-id 4361.1067620912@sss.pgh.pa.us
Whole thread Raw
In response to PQunescapeBytea code  ("Jeroen T. Vermeulen" <jtv@xs4all.nl>)
List pgsql-hackers
"Jeroen T. Vermeulen" <jtv@xs4all.nl> writes:
> This code completely ignores any other usage of the backslash in the
> escaped string, generating no output for unknown escape sequences.  Is 
> that the desired behaviour?

As Adam pointed out, the code does do the right thing for other
backslash sequences; it just processes the character on the following
loop iteration.  I'll add a comment to explain this.

I see another issue here, which is that for a zero-length input string
we will do malloc(0) and realloc(foo, 0), neither of which are very
portable.  Will fix.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Experimental patch for inter-page delay in VACUUM
Next
From: Jan Wieck
Date:
Subject: Re: Experimental patch for inter-page delay in VACUUM