Re: Cygwin - make check broken - Mailing list pgsql-hackers

er that would be this patch.

Andrew Dunstan wrote:

>
>
> Tom Lane wrote:
>
>> "Rocco Altier" <RoccoA@Routescape.com> writes:
>>
>>
>>> It looks like when we changed regress/GNUmakefile to pull rules from
>>> Makefile.shlib, cygwin got broken in the process.
>>> ...
>>> I don't know enough about the rest of the way the cygwin port is put
>>> together, but it seems that the other platforms all have
>>> shlib=lib$(NAME)...
>>>
>>
>> Seems to me that defining shlib that way for Cygwin too would be a
>> reasonable answer, but I'm not sure if there will be any side-effects.
>> Can someone try it?
>>
>>
>>
>>
>
> The attached patch worked for me. The second part should not be
> applied - I simply include it to illustrate the hack (taken from a
> recent clue on the Cygwin mailing list) that I found necessary to get
> around brokenness on the latest release of Cygwin. The good news is
> that they do seem to be trying to find out what broke and fix it.
>
>
Index: src/Makefile.shlib
===================================================================
RCS file: /projects/cvsroot/pgsql/src/Makefile.shlib,v
retrieving revision 1.95
diff -c -r1.95 Makefile.shlib
*** src/Makefile.shlib    13 Jul 2005 17:00:44 -0000    1.95
--- src/Makefile.shlib    7 Aug 2005 13:21:58 -0000
***************
*** 234,240 ****
  endif

  ifeq ($(PORTNAME), cygwin)
!   shlib            = $(NAME)$(DLSUFFIX)
    # needed for /contrib modules, not sure why
    SHLIB_LINK        += $(LIBS)
    haslibarule   = yes
--- 234,240 ----
  endif

  ifeq ($(PORTNAME), cygwin)
!   shlib            = lib$(NAME)$(DLSUFFIX)
    # needed for /contrib modules, not sure why
    SHLIB_LINK        += $(LIBS)
    haslibarule   = yes
Index: src/backend/storage/file/fd.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/storage/file/fd.c,v
retrieving revision 1.118
diff -c -r1.118 fd.c
*** src/backend/storage/file/fd.c    4 Jul 2005 04:51:48 -0000    1.118
--- src/backend/storage/file/fd.c    7 Aug 2005 13:22:00 -0000
***************
*** 327,332 ****
--- 327,334 ----
                  elog(WARNING, "dup(0) failed after %d successes: %m", used);
              break;
          }
+         if (used >= 250)
+             break;

          if (used >= size)
          {