Re: pgsql: Regression tests for security_barrier views. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Regression tests for security_barrier views.
Date
Msg-id 4277.1327089502@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Regression tests for security_barrier views.  (Robert Haas <rhaas@postgresql.org>)
Responses Re: pgsql: Regression tests for security_barrier views.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
Robert Haas <rhaas@postgresql.org> writes:
> Regression tests for security_barrier views.

This patch broke the regression tests for any scenario where you run the
tests multiple times without an initdb, because it creates a role and
fails to drop it.

More generally, please do not use role names as generic as "alice" in
regression tests, as that could have disastrous effects if someone
were to run the regression tests in a live installation.  We have a
convention of using "regressuser1" and so forth.

            regards, tom lane

pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: pgsql: Check number of fields in IDENTIFY_SYSTEM response
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Regression tests for security_barrier views.