Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit() - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
Date
Msg-id 4259.1458237730@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-committers
Teodor Sigaev <teodor@sigaev.ru> writes:
>> It should go through SetConfigOption(); compare for example
>> tsa_set_curcfg_byname().  Which would also mean you could drop the

> Seems, also show_limit() should use GetConfigOption()?

Nah, that's overkill.  The current contents of similarity_threshold are
always the current state of the GUC variable.  The problem with just
assigning to the variable is that then guc.c doesn't know what you did
and might overwrite the value later.

            regards, tom lane


pgsql-committers by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
Next
From: Tom Lane
Date:
Subject: pgsql: Fix assorted breakage in to_char()'s OF format option.