RE: Use of "long" in incremental sort code - Mailing list pgsql-hackers

From Tang, Haiying
Subject RE: Use of "long" in incremental sort code
Date
Msg-id 4250be9d350c4992abb722a76e288aef@G08CNEXMBPEKD05.g08.fujitsu.local
Whole thread Raw
In response to Use of "long" in incremental sort code  (David Rowley <dgrowleyml@gmail.com>)
Responses RE: Use of "long" in incremental sort code  ("Tang, Haiying" <tanghy.fnst@cn.fujitsu.com>)
List pgsql-hackers
Hi

Found one more place needed to be changed(long -> int64).

Also changed the output for int64 data(Debug mode on & define EXEC_SORTDEBUG )

And, maybe there's a typo in " src\backend\executor\nodeIncrementalSort.c" as below.
Obviously, the ">=" is meaningless, right?

-        SO1_printf("Sorting presorted prefix tuplesort with >= %ld tuples\n", nTuples);
+        SO1_printf("Sorting presorted prefix tuplesort with %ld tuples\n", nTuples);

Please take a check at the attached patch file.

Previous disscution:
https://www.postgresql.org/message-id/CAApHDvpky%2BUhof8mryPf5i%3D6e6fib2dxHqBrhp0Qhu0NeBhLJw%40mail.gmail.com

Best regards
Tang




Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication
Next
From: "tsunakawa.takay@fujitsu.com"
Date:
Subject: RE: [POC] Fast COPY FROM command for the table with foreign partitions