Re: Display Pg buffer cache (WIP) - Mailing list pgsql-patches

From Neil Conway
Subject Re: Display Pg buffer cache (WIP)
Date
Msg-id 422AC401.3020702@samurai.com
Whole thread Raw
In response to Re: Display Pg buffer cache (WIP)  (Mark Kirkwood <markir@coretech.co.nz>)
List pgsql-patches
Only two things to add: you forgot to add `cachedump.o' to the list of
OBJS in the utils/adt Makefile.

Mark Kirkwood wrote:
> +typedef struct
> +{
> +    uint32        bufferid;
> +    Oid            relfilenode;
> +    Oid            reltablespace;
> +    Oid            reldatabase;
> +    bool        isdirty;
> +    uint32        refcount;
> +    BlockNumber    blocknum;
> +
> +} CacheDumpRec;

You should probably make `isdirty' the last member of this struct, so as
to reduce alignment/padding requirements (this won't actually save any
space right now, but it might save some space if more members are added
to the struct in the future).

-Neil

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: Display Pg buffer cache (WIP)
Next
From: Pavel Stehule
Date:
Subject: Implementation of SQLCODE and SQLERRM variables for PL/pgSQL