Re: dmetaphone woes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: dmetaphone woes
Date
Msg-id 422.1270433061@sss.pgh.pa.us
Whole thread Raw
In response to dmetaphone woes  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: dmetaphone woes  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> While testing pgindent the other day, I found some infelicities in 
> contrib/fuzzystrmatch/dmetaphone.c. From pgindent's point of view, the 
> problem is that the code contains two characters in case labels with the 
> high bits set, and this blows pgindent up on my Linux box if the locale 
> happens be en_US.utf8 instead of C.

Not only pgindent ...
http://archives.postgresql.org/pgsql-hackers/2008-10/msg00308.php

> However, that doesn't solve the fundamental problem, which is that the 
> code in question is pretty much broken for any encoding but Latin1.

Yeah.  I don't see an easy fix for it either, but there should be a
TODO entry about it.  In the meantime I'm surprised we didn't insert
octal escapes already.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: default privileges
Next
From: Bruce Momjian
Date:
Subject: Re: pgindent bizarreness