Re: Performance tweaks - Mailing list pgsql-jdbc

From Oliver Jowett
Subject Re: Performance tweaks
Date
Msg-id 421BAF50.3020701@opencloud.com
Whole thread Raw
In response to Performance tweaks  (Ken Geis <kgeis@speakeasy.net>)
Responses Re: Performance tweaks  (Ken Geis <kgeis@speakeasy.net>)
Re: Performance tweaks  (Ken Geis <kgeis@speakeasy.net>)
List pgsql-jdbc
Ken Geis wrote:

> First, in PGStream, I "unrolled" SendInteger4 and SendInteger2, like this:
>
>     private static final byte[] B4 = new byte[4];
>     public void SendInteger4(int val) throws IOException
>     {
>         B4[0] = (byte) ((val >> 24)&255);
>         B4[1] = (byte) ((val >> 16)&255);
>         B4[2] = (byte) ((val >> 8)&255);
>         B4[3] = (byte) (val&255);
>         pg_output.write(B4, 0, 4);
>     }

This isn't safe across multiple PGStreams. Can you try benchmarking
again with "private final" instead of "private static final"? If that's
still a win it is probably worth changing.

-O

pgsql-jdbc by date:

Previous
From: Oliver Jowett
Date:
Subject: Re: Performance tweaks
Next
From: Oliver Jowett
Date:
Subject: Re: Performance tweaks