Stats target increase vs compute_tsvector_stats() - Mailing list pgsql-hackers

From Tom Lane
Subject Stats target increase vs compute_tsvector_stats()
Date
Msg-id 4207.1229191369@sss.pgh.pa.us
Whole thread Raw
Responses Re: Stats target increase vs compute_tsvector_stats()
Re: Stats target increase vs compute_tsvector_stats()
List pgsql-hackers
I started making the changes to increase the default and maximum stats
targets 10X, as I believe was agreed to in this thread:
http://archives.postgresql.org/pgsql-hackers/2008-12/msg00386.php

I came across this bit in ts_typanalyze.c:
/* We want statistic_target * 100 lexemes in the MCELEM array */num_mcelem = stats->attr->attstattarget * 100;

I wonder whether the multiplier here should be changed?  This code is
new for 8.4, so we have zero field experience about what desirable
lexeme counts are; but the prospect of up to a million lexemes in
a pg_statistic entry doesn't seem quite right.  I'm tempted to cut the
multiplier to 10 so that the effective range of MCELEM sizes remains
the same as what Jan had in mind when he wrote the code.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Robert Haas"
Date:
Subject: Re: WIP: default values for function parameters
Next
From: "Robert Haas"
Date:
Subject: Re: Sync Rep: First Thoughts on Code