15 July 2014 19:29 Amit Kapila Wrote,
>Implementation details:
-----------------------------------
>1. This feature is implemented only for tar format in windows
>as native windows utilites are not able to create symlinks while
>extracting files from tar (It might be possible to create symlinks
>if cygwin is installed on your system, however I feel we need this
>feature to work for native windows as well). Another reason to not
>create it for non-tar (plain) format is that plain format can update the
>symlinks via -T option and backing up symlink file during that
>operation can lead to spurious symlinks after archive recovery.
I have reviewed the patch and did not find any major comments.
There are some comments I would like to share with you
1. Rebase the patch to current GIT head.
2. + * Construct symlink file
+ */
+ initStringInfo(&symlinkfbuf);
I think declaration and initialization of symlinkfbuf string can be moved under #ifdef WIN32 compile time macro,
for other platform it’s simply allocated and freed which can be avoided.
3. + /*
+ * native windows utilites are not able create symlinks while
+ * extracting files from tar.
+ */
Rephrase the above sentence and fix spelling mistake (utilities are not able to create)
I haven’t done the testing yet, once I finish with testing i will share the result with you.
Regards,
Dilip
