Re: pg_basebackup vs. Windows and tablespaces - Mailing list pgsql-hackers

<div class="WordSection1"><p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">15 July
201419:29 Amit Kapila Wrote,</span><p class="MsoNormal"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><pclass="MsoNormal">>Implementation details:<p
class="MsoNormal">-----------------------------------<pclass="MsoNormal">>1. This feature is implemented only for
tarformat in windows<p class="MsoNormal">>as native windows utilites are not able to create symlinks while<p
class="MsoNormal">>extractingfiles from tar (It might be possible to create symlinks<p class="MsoNormal">>if
cygwinis installed on your system, however I feel we need this<p class="MsoNormal">>feature to work for native
windowsas well).  Another reason to not<p class="MsoNormal">>create it for non-tar (plain) format is that plain
formatcan update the<p class="MsoNormal">>symlinks via -T option and backing up symlink file during that<p
class="MsoNormal">>operationcan lead to spurious symlinks after archive recovery.  <p class="MsoNormal"> <p
class="MsoNormal">Ihave reviewed the patch and did not find any major comments.<p class="MsoNormal"> <p
class="MsoNormal">Thereare some comments I would like to share with you<p class="MsoNormal"> <p
class="MsoListParagraph"style="text-indent:-18.0pt;mso-list:l0 level1 lfo1"><span style="mso-list:Ignore">1.<span
style="font:7.0pt"Times New Roman"">      </span></span>Rebase the patch to current GIT head.<p
class="MsoListParagraph"> <pclass="MsoListParagraph" style="text-indent:-18.0pt;mso-list:l0 level1 lfo1"><span
style="mso-list:Ignore">2.<spanstyle="font:7.0pt "Times New Roman"">      </span></span>+                      *
Constructsymlink file<p class="MsoListParagraph">+                      */<p
class="MsoListParagraph">+                     initStringInfo(&symlinkfbuf);<p class="MsoNormal">            I
thinkdeclaration and initialization of symlinkfbuf string can be moved under #ifdef WIN32 compile time macro, <p
class="MsoNormal"style="text-indent:36.0pt">for other platform it’s simply allocated and freed which can be avoided. <p
class="MsoNormal"style="text-indent:36.0pt"> <p class="MsoListParagraph" style="text-indent:-18.0pt;mso-list:l0 level1
lfo1"><spanstyle="mso-list:Ignore">3.<span style="font:7.0pt "Times New Roman"">     
</span></span>+                                 /*<p class="MsoListParagraph">+                                  *
nativewindows utilites are not able create symlinks while<p class="MsoListParagraph">+                                 
*extracting files from tar.<p class="MsoListParagraph">+                                  */<p class="MsoNormal"
style="text-indent:36.0pt"> <pclass="MsoNormal">            Rephrase the above sentence and fix spelling mistake
 (<b>utilities</b>are not able <b>to</b> create)<p class="MsoNormal"> <p class="MsoNormal">I haven’t done the testing
yet,once I finish with testing i will share the result with you.<p class="MsoNormal"> <p class="MsoNormal"> <p
class="MsoNormal">Regards,<pclass="MsoNormal">Dilip<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span></div>