Re: convert elog(LOG) calls to ereport - Mailing list pgsql-hackers

On 2020-12-02 15:04, Alvaro Herrera wrote:
>> -        elog(LOG, "WSAIoctl(SIO_KEEPALIVE_VALS) failed: %ui",
>> -             WSAGetLastError());
>> +        ereport(LOG,
>> +                (errmsg("WSAIoctl(SIO_KEEPALIVE_VALS) failed: %ui",
>> +                        WSAGetLastError())));
> 
> Please take the opportunity to move the flag name out of the message in
> this one, also.

done

> I do wonder if it'd be a good idea to move the syscall
> name itself out of the message, too; that would reduce the number of
> messages to translate 50x to just "%s(%s) failed: %m" instead of one
> message per distinct syscall.

Seems useful, but perhaps as a separate project.

> Should fd.c messages do errcode_for_file_access() like elsewhere?

yes, done