Re: issue in pgfdw_report_error()? - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: issue in pgfdw_report_error()?
Date
Msg-id 41aae5d4-4d11-85f6-8f32-1bb5349ce959@oss.nttdata.com
Whole thread Raw
In response to Re: issue in pgfdw_report_error()?  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: issue in pgfdw_report_error()?
List pgsql-hackers

On 2021/11/19 21:57, Bharath Rupireddy wrote:
>> If this is a bug, IMO the following change needs to be applied. Thought?
>>
>> -------------------
>>                   ereport(elevel,
>>                                   (errcode(sqlstate),
>> -                                message_primary ? errmsg_internal("%s", message_primary) :
>> +                                (message_primary != NULL && message_primary[0] != '\0') ?
>> +                                errmsg_internal("%s", message_primary) :
>>                                    errmsg("could not obtain message string for remote error"),
>> -------------------

I attached the patch.


> What if conn->errorMessage.data is NULL and PQerrorMessage returns it?
> The message_primary can still be NULL right?

Since conn->errorMessage is initialized by initPQExpBuffer(),
PQerrorMessage() seems not to return NULL. But *if* it returns NULL,
pchomp(NULL) is executed and would cause a segmentation fault.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachment

pgsql-hackers by date:

Previous
From: Dinesh Chemuduru
Date:
Subject: Re: Pasword expiration warning
Next
From: Robert Haas
Date:
Subject: Re: Frontend error logging style