Re: sparse (static analyzer) report - Mailing list pgsql-hackers

From Neil Conway
Subject Re: sparse (static analyzer) report
Date
Msg-id 41EA4E35.6080005@samurai.com
Whole thread Raw
In response to Re: sparse (static analyzer) report  (Mark Wong <markw@osdl.org>)
List pgsql-hackers
Mark Wong wrote:
> Ah, so you beat me to it Neil. ;)  Out of curiosity, how much worse
> was it before you started fixing things?

As I recall, not too different than things are today -- sparse flagged a 
bunch of stylistic issues that I fixed, like:

void some_func() { ... } => void some_func(void) { ... }

extern void some_func(void) { ... } => void some_func(void) { ... }

etc. But given that there are 3000 odd warnings (mostly bogus), I doubt 
I made a significant dent on the total warning count.

Also, I don't recall sparse picking up any significant errors or 
problems. As I said, I've been meaning to explore if that's all that 
sparse can do -- I just looked at the lowest of the low-hanging fruit.

-Neil


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Encodings and docs
Next
From: lsunley@mb.sympatico.ca
Date:
Subject: Re: OS/2 port regression tests