Re: pg_hba.conf can't write - Mailing list pgadmin-hackers

From Andreas Pflug
Subject Re: pg_hba.conf can't write
Date
Msg-id 41C1B466.5070603@pse-consulting.de
Whole thread Raw
In response to Re: pg_hba.conf can't write  ("Hiroshi Saito" <saito@inetrt.skcapi.co.jp>)
List pgadmin-hackers
Hiroshi Saito wrote:

>
> However, It can't change into the comment line.
> Please apply it.
>

> ------------------------------------------------------------------------
>
> --- src/ui/dlgHbaConfig.cpp.orig    Thu Dec 16 02:07:11 2004
> +++ src/ui/dlgHbaConfig.cpp    Thu Dec 16 02:07:39 2004
> @@ -297,7 +297,7 @@
>
>      }
>      btnOK->Enable(cbType->GetSelection() >= 0 && !database.IsEmpty() && !user.IsEmpty() &&
> -            cbMethod->GetSelection() >= 0 && ipValid);
> +            cbMethod->GetSelection() >= 0);

I don't like this fix. The check is ok, but ipValid is wrong;
preliminarily fixed.
Maybe you find the time to implement the checking code in line 298ff for
IPV4 an IPV6 and both flavours of netmasks.

Regards,
Andreas

pgadmin-hackers by date:

Previous
From: cvs@developer.pgadmin.org
Date:
Subject: CVS Commit by andreas: preliminary fix for ip address checking
Next
From: cvs@developer.pgadmin.org
Date:
Subject: CVS Commit by andreas: fix writing dlg_hba.conf