Re: fix compile warning for pg_backup_tar.c - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: fix compile warning for pg_backup_tar.c
Date
Msg-id 418FC7C9.8070105@dunslane.net
Whole thread Raw
In response to Re: fix compile warning for pg_backup_tar.c  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: fix compile warning for pg_backup_tar.c  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches

Peter Eisentraut wrote:

>Andrew Dunstan wrote:
>
>
>>ISTM that what is happening here is that the compiler is smart enough
>>to know that what is in MAX_TAR_MEMBER_FILELEN can't be exceeded by
>>any possible value of type off_t.
>>
>>
>
>Yeah, I think off_t is only 32 bits there.  Then using INT64_IS_BUSTED
>as conditional is really misleading.\
>
>

What would you like me to use? Or maybe we should just do this in all
cases instead of using an ifdef?

cheers

andrew

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: fix compile warning for pg_backup_tar.c
Next
From: Neil Conway
Date:
Subject: GiST: perf. work, index tuple killing